Skip to content

Added angular-eslint notice to README.md #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 21, 2021

PR Checklist

Overview

Since there's some additional schematic logics that needs to happen external to this tool, I think the best resolution for #948 for now is to defer it to angular-eslint.

I can file a separate issue about investigating framework-specific logs. Should they be emphasized extra loudly? Block CLI running unless a flag is passed? That seems outside the scope of this ticket.

@JoshuaKGoldberg
Copy link
Member Author

😬 I've gotten so used to repositories that auto-request reviewers I forgot to manually do it here...!

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Feb 24, 2021
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with it as it is easier to spot latest changes at angular-eslint for Angular-specific rules instead of hardcode the logic in this repository.

@JamesHenry
Copy link
Member

Thanks Josh, there are a small minority of Angular users that do not use the Angular CLI, so I just want to spend some time thinking about where it's best to support them most effectively. I'll aim to do that this weekend and revert back

@JoshuaKGoldberg
Copy link
Member Author

@JamesHenry I'll go ahead and merge this now. I get the drift this is at least a step in the right direction. Let me know if we should revert/switch!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4559f44 into main Mar 11, 2021
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Mar 11, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the angular-readme-notice branch March 11, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

banana-in-box should output '@angular-eslint/template-parser' as the parser
3 participants