Added angular-eslint notice to README.md #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😬 I've gotten so used to repositories that auto-request reviewers I forgot to manually do it here...! |
JoshuaKGoldberg
added
the
status: waiting for reviewer
KingDarBoja
approved these changes
Feb 24, 2021
|
Thanks Josh, there are a small minority of Angular users that do not use the Angular CLI, so I just want to spend some time thinking about where it's best to support them most effectively. I'll aim to do that this weekend and revert back |
|
@JamesHenry I'll go ahead and merge this now. I get the drift this is at least a step in the right direction. Let me know if we should revert/switch! |
JoshuaKGoldberg
removed
the
status: waiting for reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Since there's some additional schematic logics that needs to happen external to this tool, I think the best resolution for #948 for now is to defer it to angular-eslint.
I can file a separate issue about investigating framework-specific logs. Should they be emphasized extra loudly? Block CLI running unless a flag is passed? That seems outside the scope of this ticket.